Migrate to Globus SDK's GlobusApp #646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces the custom GlobusAuthManager classes with functions for creating GlobusApp instances. This reduces a lot of boilerplate code around performing login flows, saving tokens, etc., and will better extending scopes as needed and rerunning login flows.
This is a breaking change to the
proxystore.globusAPIs but those interfaces are designed for internal use so there won't be breaking changes to regular applications. (I'm assuming no one is using ProxyStore's Globus Auth tooling to develop their own applications.) This should also be backwards compatible with existing user tokens.The miniumum globus-sdk version is now >=3.46.0.
This is a breaking change to the APIs in
proxystore.globus, though anyone using the typical ProxyStore APIs will not be affected.Fixes
GlobusAuthManagerto the Globus SDK'sGlobusApp#620Type of Change
Testing
Added new tests, and tried login flow CLI + endpoint auth.
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., mypy, ruff, etc.).