Skip to content

Improve which relay registration errors are raised versus retried #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gpauloski merged 2 commits into from
Aug 29, 2024
Merged

Improve which relay registration errors are raised versus retried #621

gpauloski merged 2 commits into from
Aug 29, 2024

Conversation

@gpauloski
Copy link
Collaborator

@gpauloski gpauloski commented Aug 29, 2024

Description

Authentication errors (unauthorized/forbidden) are now raised since they are mostly unrecoverable from and require user intervention. Address failures (socket.gaierror) are caught and retried.

Fixes

Type of Change

  • Breaking Change (fix or enhancement which changes existing semantics of the public interface)
  • Enhancement (new features or improvements to existing functionality)
  • Bug (fixes for a bug or issue)
  • Internal (refactoring, style changes, testing, optimizations)
  • Documentation update (changes to documentation or examples)
  • Package (dependencies, versions, package metadata)
  • Development (CI workflows, pre-commit, linters, templates)
  • Security (security related changes)

Testing

Update test cases.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
  • Code changes pass pre-commit (e.g., mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski
Skip relay connect retry on unrecoverable errors
c03c600 
Fixed #619 by checking the status code of ConnectionClosed
errors when registering and raises the error if it is unrecoverable
(rather than waiting and retrying). Right now, forbidden and
unauthorized are the only "unrecoverable" errors returned by the relay
server.
@gpauloski
Retry relay client registration on address errors
efafd6b 
Catches socket.gaierror which is related to address lookups. I noted a
user that experienced this often in #619, and it appears related to
temporary DNS failures. These should always be retried.
@gpauloski gpauloski added the bug Error, flaw, or fault that causes unexpected behavior label Aug 29, 2024
@gpauloski gpauloski merged commit 960d5ff into main Aug 29, 2024
@gpauloski gpauloski deleted the issue-619 branch August 29, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Error, flaw, or fault that causes unexpected behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Avoid relay registration retry for certain registration failures

2 participants

@gpauloski