Skip to content

Conversation

@gpauloski
Copy link
Collaborator

Description

The tests/store/executor_test.py::test_default_behaviour[ThreadPoolExecutor] test would sometimes deadlock in the MacOS GitHub actions runners. This started after adding the lock to Store and LRUCache methods, so I suspect it is a deadlock there related to the slower runners with fewer cores.

Fixes N/A

Type of Change

  • Breaking Change (fix or enhancement which changes existing semantics of the public interface)
  • Enhancement (new features or improvements to existing functionality)
  • Bug (fixes for a bug or issue)
  • Internal (refactoring, style changes, testing, optimizations)
  • Documentation update (changes to documentation or examples)
  • Package (dependencies, versions, package metadata)
  • Development (CI workflows, pre-commit, linters, templates)
  • Security (security related changes)

Testing

TODO

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
  • Code changes pass pre-commit (e.g., mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski gpauloski added the bug Error, flaw, or fault that causes unexpected behavior label Aug 20, 2024
@gpauloski gpauloski force-pushed the macos-executor-deadlock branch from 9e17f4b to b697fb4 Compare August 20, 2024 15:11
@gpauloski gpauloski merged commit 8c79eff into main Aug 20, 2024
@gpauloski gpauloski deleted the macos-executor-deadlock branch August 20, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Error, flaw, or fault that causes unexpected behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants