Improve thread-safety in the Store
#609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve thread-safety in the
Storeby making theLRUCachethread safe and adding locks around connector and state changing operations in theStore.I don't anticipate this having a measurable performance impact because most applications don't perform
Storeoperations across many threads. The exception is that some applications may resolve a proxy across many threads. In that case, the changes will prevent full on crashes when the same proxy is resolved in multiple threads, but may reduce performance when different proxies/targets are resolved in different threads. However, this does not matter if the connector is also implemented with locks to prevent concurrent operations.Fixes
KeyErrorin cache eviction ofStore#604Type of Change
Testing
All test cases still pass.
I ran the TaPS example reported in #604 and this reliably fixes the issue.
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., mypy, ruff, etc.).