Skip to content

Conversation

@gpauloski
Copy link
Collaborator

Description

@KlaudiuszRydzy found that some proxies were very large when serialized which ended up being specific to the LocalConnector storing it's data dict in the connector config.

This causes proxies to unexpectedly contain all the data in the connector because the proxy stores the connector config. This was useful for some specific tests, so that feature is now available under a flag.

Fixes N/A

Type of Change

  • Breaking Change (fix or enhancement which changes existing semantics of the public interface)
  • Enhancement (new features or improvements to existing functionality)
  • Bug (fixes for a bug or issue)
  • Internal (refactoring, style changes, testing, optimizations)
  • Documentation update (changes to documentation or examples)
  • Package (dependencies, versions, package metadata)
  • Development (CI workflows, pre-commit, linters, templates)
  • Security (security related changes)

Testing

Tested serializing a proxy from a LocalConnector is small again.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
  • Code changes pass pre-commit (e.g., mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski gpauloski added the bug Error, flaw, or fault that causes unexpected behavior label Jul 31, 2024
@gpauloski gpauloski merged commit 2cc70ce into main Jul 31, 2024
@gpauloski gpauloski deleted the local-connector-config branch July 31, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Error, flaw, or fault that causes unexpected behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants