Skip to content

Conversation

@gpauloski
Copy link
Collaborator

Description

Clarify populate_target=True behavior with custom (de)serializers in Store.proxy(). I noticed this when making this example in another issue: #583 (comment).

Related to #557

Fixes N/A

Type of Change

  • Breaking Change (fix or enhancement which changes existing semantics of the public interface)
  • Enhancement (new features or improvements to existing functionality)
  • Bug (fixes for a bug or issue)
  • Internal (refactoring, style changes, testing, optimizations)
  • Documentation update (changes to documentation or examples)
  • Package (dependencies, versions, package metadata)
  • Development (CI workflows, pre-commit, linters, templates)
  • Security (security related changes)

Testing

Added a test case so we can track if behavior changes unexpectedly in the future.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
  • Code changes pass pre-commit (e.g., mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski gpauloski added the documentation Improvements or additions to documentation or examples label Jun 20, 2024
@gpauloski gpauloski merged commit 2bc3fb1 into main Jun 20, 2024
@gpauloski gpauloski deleted the issue-557-followup branch June 20, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation or examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants