Skip to content

Conversation

@gpauloski
Copy link
Collaborator

Description

See commit history.

Fixes

Type of Change

  • Breaking Change (fix or enhancement which changes existing semantics of the public interface)
  • Enhancement (new features or improvements to existing functionality)
  • Bug (fixes for a bug or issue)
  • Internal (refactoring, style changes, testing, optimizations)
  • Documentation update (changes to documentation or examples)
  • Package (dependencies, versions, package metadata)
  • Development (CI workflows, pre-commit, linters, templates)
  • Security (security related changes)

Testing

All tests pass. Fewer warnings are raised.

There is still the following warning:

  /home/jgpaul/workspace/proxystore/.tox/py311/lib/python3.11/site-packages/google_crc32c/__config__.py:18: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
    import pkg_resources

But this is because google_crc32c has not made a PyPI release in two years.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
  • Code changes pass pre-commit (e.g., mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski gpauloski added the internal Refactoring, style changes, testing, or code optimizations label Jun 7, 2024
@gpauloski gpauloski merged commit b55d1dc into main Jun 7, 2024
@gpauloski gpauloski deleted the issue-558 branch June 7, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Refactoring, style changes, testing, or code optimizations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecation/experimental warnings from package

2 participants