Skip to content

Conversation

@gpauloski
Copy link
Collaborator

Description

As mentioned in 562, kafka-python is no longer maintained and while there is a new fork, it is unclear how well that will be maintained either. This switches the Kafka stream shims to confluent-kafka.

Fixes

Type of Change

  • Breaking Change (fix or enhancement which changes existing semantics of the public interface)
  • Enhancement (new features or improvements to existing functionality)
  • Bug (fixes for a bug or issue)
  • Internal (refactoring, style changes, testing, optimizations)
  • Documentation update (changes to documentation or examples)
  • Package (dependencies, versions, package metadata)
  • Development (CI workflows, pre-commit, linters, templates)
  • Security (security related changes)

Testing

Updated unit tests and validated the shim with testing/scripts/kafka_pubsub.py.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
  • Code changes pass pre-commit (e.g., mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski gpauloski added breaking Backwards incompatible change to public interfaces package Dependencies, version changes, or package metadata labels Jun 6, 2024
@gpauloski gpauloski merged commit f6c3367 into main Jun 6, 2024
@gpauloski gpauloski deleted the issue-562 branch June 6, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Backwards incompatible change to public interfaces package Dependencies, version changes, or package metadata

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decide what to do about Kafka dependency

2 participants