Description

Rather than just fix the conversion, I've changed the Metrics class to take ms directly as input because it also returns ms. This keeps the units consistent to prevent confusion in calling code.

Fixes

• Fixes Metrics for Store instances incorrectly converts NS to MS #535

Type of Change

• Breaking Change (fix or enhancement which changes existing semantics of the public interface)
• Enhancement (new features or improvements to existing functionality)
• Bug (fixes for a bug or issue)
• Internal (refactoring, style changes, testing, optimizations)
• Documentation update (changes to documentation or examples)
• Package (dependencies, versions, package metadata)
• Development (CI workflows, pre-commit, linters, templates)
• Security (security related changes)

Testing

Updated the unit tests and used the following script to validate (1) main records the time wrong and (2) this branch does it right.

import os
import pprint
import tempfile
import time

from proxystore.connectors.file import FileConnector
from proxystore.store import Store

with tempfile.TemporaryDirectory() as tmp_dir:
    start = time.perf_counter_ns()
    with open(os.path.join(tmp_dir, 'test'), 'w') as f:
        f.write('value')
    end = time.perf_counter_ns()

    print('Write time (ms):', (end - start) / 1000_000)


with tempfile.TemporaryDirectory() as tmp_dir:
    with Store('test', FileConnector(tmp_dir), metrics=True) as store:
        key = store.put('value')
        store.get(key)

        pprint.pprint(store.metrics.get_metrics(key))import os

The times for Write time (ms) and store.put.connector should be similar (and not off by 1000x).

Pull Request Checklist

• I have read the Contributing and PR submission guides.

Please confirm the PR meets the following requirements.

• Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
• Code changes pass pre-commit (e.g., mypy, ruff, etc.).
• Tests have been added to show the fix is effective or that the new feature works.
• New and existing unit tests pass locally with the changes.
• Docs have been updated and reviewed if relevant.