Improve serialization error handling when resolving a proxy #531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a proxy is resolved and it's deserializer raises an
AttributeError, the proxy raises a vagueAttributeError: __wrapped__.For example, this code raises the following stacktrace.
This PR improve serialization handling to:
SerializationErrorStore.get()I wanted to be able to log the deserializer used that caused the issues. This required changing
get_class_pathto support more than classes, so I changed it to support arbitrary objects.Fixes
AttributeError: __wrapped__#530Type of Change
Testing
Added unit tests.
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., mypy, ruff, etc.).