Handle and pass on SIGINT propagated by Uvicorn after cleanup #514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uvicorn 0.29.0 no longer captures, handles, and then surpresses SIGINT. Rather, SIGINT is repropagated by Uvicorn so we need to capture it again and pass. It is safe to pass because we let Uvicorn handle clean up for the endpoint.
Fixes
Type of Change
Testing
I tested with this script on the old and new versions of uvicorn by starting the script and then sending each signal type with
kill -s SIGTERM [PID].Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., mypy, ruff, etc.).