Fix Store.put_batch() called with empty list in StreamProducer.flush_topic()
#503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This would happen when a StreamProducer is closed and there are no objects in the current batch buffer. A lot of connector implementations, such as the ones used to test the StreamProducer, are okay with put_batch([]) but the RedisConnector raises an error here. Maybe in the future we should support empty batches in put_batch() as a part of the Connector protocol, but it is definitely not needed to call put_batch in the StreamProducer in this case.
Fixes N/A
Type of Change
Testing
All test pass and verified the fix solved the problem in the benchmark suite that I ran into with Redis.
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., mypy, ruff, etc.).