Add backwards compatibility for Pydantic V1 #501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add backwards compatibility for Pydantic V1. While running some benchmarks, it's become clear that Pydantic V1 compatibility is still more important than I expected. Specifically, the
globus_compute_commonandcolmenapackages used by the benchmark suite are still pinned topydantic<2.0.0.There are no breaking changes here.
Fixes N/A
Type of Change
Testing
I manually ran the test suite in a venv with pydantic V1 installed. Note that all of the pydantic V1 branches are
pragma: no cover. While maybe suboptimal, I have marked V1 compatibility as deprecated and I don't think it's worth the extra time of running the test suite twice with each version.I don't anticipate the compatibility code be changed (or really much of the config load/dump at all), but if it does changes we'll have to be careful about testing against both versions.
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., mypy, ruff, etc.).