Skip to content

Conversation

@gpauloski
Copy link
Collaborator

Description

It is somewhat misleading to call this a ProxyFuture because that could imply it is a proxy, but really it's just a concurrent.futures like interface with an extra method for create a proxy that will resolve to the result of the future.

This is a breaking change, but the ProxyFuture was added recently and it is unlikely most code is importing that object.

Fixes

Type of Change

  • Breaking Change (fix or enhancement which changes existing semantics of the public interface)
  • Enhancement (new features or improvements to existing functionality)
  • Bug (fixes for a bug or issue)
  • Internal (refactoring, style changes, testing, optimizations)
  • Documentation update (changes to documentation or examples)
  • Package (dependencies, versions, package metadata)
  • Development (CI workflows, pre-commit, linters, templates)
  • Security (security related changes)

Testing

N/A

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
  • Code changes pass pre-commit (e.g., mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

It is somewhat misleading to call this a ProxyFuture because that could
imply it is a proxy, but really it's just a concurrent.futures like
interface with an extra method for create a proxy that will resolve to
the result of the future.
@gpauloski gpauloski added the breaking Backwards incompatible change to public interfaces label Feb 13, 2024
@gpauloski gpauloski merged commit f422d10 into main Feb 13, 2024
@gpauloski gpauloski deleted the issue-484 branch February 13, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Backwards incompatible change to public interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename ProxyFuture to Future

2 participants