Skip to content

Conversation

@gpauloski
Copy link
Collaborator

Description

While the iter(consumer) and next(consumer) are the recommended ways to use the StreamConsumer, it can be particularly helpful for testing and debugging to have a mechanism to iterate on the objects directly.

Fixes N/A

Type of Change

  • Breaking Change (fix or enhancement which changes existing semantics of the public interface)
  • Enhancement (new features or improvements to existing functionality)
  • Bug (fixes for a bug or issue)
  • Internal (refactoring, style changes, testing, optimizations)
  • Documentation update (changes to documentation or examples)
  • Package (dependencies, versions, package metadata)
  • Development (CI workflows, pre-commit, linters, templates)
  • Security (security related changes)

Testing

Added new tests and simplified some old tests using the new methods.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
  • Code changes pass pre-commit (e.g., mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

While the iter(consumer) and next(consumer) are the recommended ways to
use the StreamConsumer, it can be particularly helpful for testing and
debugging to have a mechanism to iterate on the objects directly.
@gpauloski gpauloski added the enhancement New features or improvements to existing functionality label Feb 3, 2024
@gpauloski gpauloski merged commit a42ba82 into main Feb 3, 2024
@gpauloski gpauloski deleted the stream-iter-objs branch February 3, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or improvements to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants