Skip to content

Add the ZeroMQPublisher and ZeroMQSubscriber for use with ProxyStore streams #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gpauloski merged 2 commits into from
Jan 19, 2024
Merged

Add the ZeroMQPublisher and ZeroMQSubscriber for use with ProxyStore streams #453

gpauloski merged 2 commits into from
Jan 19, 2024

Conversation

@gpauloski
Copy link
Collaborator

@gpauloski gpauloski commented Jan 19, 2024

Description

Adds the ZeroMQPublisher and ZeroMQSubscriber interfaces for using ZeroMQ PUB/SUB with the ProxyStore stream interface.

Fixes

Type of Change

  • Breaking Change (fix or enhancement which changes existing semantics of the public interface)
  • Enhancement (new features or improvements to existing functionality)
  • Bug (fixes for a bug or issue)
  • Internal (refactoring, style changes, testing, optimizations)
  • Documentation update (changes to documentation or examples)
  • Package (dependencies, versions, package metadata)
  • Development (CI workflows, pre-commit, linters, templates)
  • Security (security related changes)

Testing

Added unit tests.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
  • Code changes pass pre-commit (e.g., mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski gpauloski added the enhancement New features or improvements to existing functionality label Jan 19, 2024
@gpauloski gpauloski force-pushed the issue-450 branch 2 times, most recently from f61b763 to a375f1e Compare January 19, 2024 23:21
@gpauloski
Fix hanging ZeroMQ PUB/SUB test on MacOS
ae6acc1 
The interaction between threads/processes and ZeroMQ sockets/contexts on
MacOS and Ubuntu seems to be different, so I'm just going to mock the
send/recv methods to test the functionality of the interface.
@gpauloski gpauloski merged commit 1fdb4d1 into main Jan 19, 2024
@gpauloski gpauloski deleted the issue-450 branch January 19, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New features or improvements to existing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ZeroMQPublisher/ZeroMQSubscriber implementations for ZeroMQ PUB/SUB

2 participants

@gpauloski