Skip to content

Conversation

@gpauloski
Copy link
Collaborator

Description

Adds the RedisPublisher and RedisSubscriber interfaces for using Redis pub/sub with the ProxyStore stream interface.

Fixes

Type of Change

  • Breaking Change (fix or enhancement which changes existing semantics of the public interface)
  • Enhancement (new features or improvements to existing functionality)
  • Bug (fixes for a bug or issue)
  • Internal (refactoring, style changes, testing, optimizations)
  • Documentation update (changes to documentation or examples)
  • Package (dependencies, versions, package metadata)
  • Development (CI workflows, pre-commit, linters, templates)
  • Security (security related changes)

Testing

Added unit tests using mock Redis client.

Also added the testing/scripts/redis_pubsub.py script for running against an actual Redis server.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
  • Code changes pass pre-commit (e.g., mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

Added unit tests using the existing mock Redis client we have, but also
added a script to test the basic functionality against a real Redis
server.
@gpauloski gpauloski added the enhancement New features or improvements to existing functionality label Jan 18, 2024
@gpauloski gpauloski merged commit 77cd12e into main Jan 18, 2024
@gpauloski gpauloski deleted the issue-448 branch January 18, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or improvements to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add RedisPublisher/RedisSubscriber implementations for Redis Pub/Sub

2 participants