Add prototype streaming interface #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is to maintain the original interface worked on by Naz1380 and valhayot in the streaming branch. Due to the limitations outlined in Issue #442 and challenges with rebasing the original streaming branch on to main, I've decided to start the implementation of Issue #442 from scratch. That said, I wanted to maintain the authorship and original interface in the commit history so I've copied the main streaming.py file here. I've left out the custom modifications to the Connector interfaces because they are pretty bespoke to this specific interface. The next commit will essentially be modifying the streaming interface here to match that of Issue #442. Co-authored-by: Naz1380 <he4687@wayne.edu> Co-authored-by: valhayot <valeriehayot@gmail.com>
This was referenced Jan 17, 2024
Fixes the following error with multiprocessing on MacOS: AttributeError: Can't pickle local object 'test_multiprocessing_send_messages.<locals>.subscribe'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #442 for a detailed history/explanation of this feature.
This PR adds a
StreamProducer/StreamConsumerinterface for streaming objects via proxies. These interfaces combine aStorefor bulk object storage and serialization with a pub/sub system for event notification.Currently, only a simple queue-based pub/sub implementation is provided. Later PRs will add interfaces to other such as Redis and Kafka.
For now, these features are marked as experimental.
Fixes
Type of Change
Testing
New tests added for all features.
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., mypy, ruff, etc.).