Switch from dataclasses to Pydantic BaseModels for configuration classes #446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches configuration models from Python dataclasses to Pydantic BaseModels. Since dataclasses don't provide type validation, we previously used
tosholito do type validation, but Pydantic provides better type validation support and better maintenance. Becausetosholiis no longer needed, I've added theproxystore.utils.configmodule with TOML configuration file loading/dumping.Fixes
tosholitopydanticfor config loading #443Type of Change
Testing
Added new unit tests where relevant and updated old unit tests. Also verified that endpoint config loading worked from the CLI with new and old configs.
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., mypy, ruff, etc.).