Skip to content

Conversation

@gpauloski
Copy link
Collaborator

Description

The logging check looks at the specific index of the log message which makes some unnecessarily strict assumptions that there will be no extra logging before the log messages we are looking for. This caused a failure in the MacOS Py3.9 CI.

Fixes N/A

Type of Change

  • Breaking Change (fix or enhancement which changes existing semantics of the public interface)
  • Enhancement (new features or improvements to existing functionality)
  • Bug (fixes for a bug or issue)
  • Internal (refactoring, style changes, testing, optimizations)
  • Documentation update (changes to documentation or examples)
  • Package (dependencies, versions, package metadata)
  • Development (CI workflows, pre-commit, linters, templates)
  • Security (security related changes)

Testing

Tests pass.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
  • Code changes pass pre-commit (e.g., mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

The logging check looks at the specific index of the log message which
makes some unnecessarily strict assumptions that there will be no extra
logging before the log messages we are looking for. This caused
a failure in the MacOS Py3.9 CI.
@gpauloski gpauloski added the internal Refactoring, style changes, testing, or code optimizations label Dec 12, 2023
@gpauloski gpauloski merged commit e46a707 into main Dec 12, 2023
@gpauloski gpauloski deleted the nat-check-logging-test branch December 12, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Refactoring, style changes, testing, or code optimizations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants