Skip to content

Conversation

@gpauloski
Copy link
Collaborator

Description

Upgrades to pytest_asyncio>=0.23.2. Note that the relay_server fixture needed to be changed from session to function scope. This makes the test suite a bit slower (but it's only a half second on my desktop).

Fixes

Type of Change

  • Breaking Change (fix or enhancement which changes existing semantics of the public interface)
  • Enhancement (new features or improvements to existing functionality)
  • Bug (fixes for a bug or issue)
  • Internal (refactoring, style changes, testing, optimizations)
  • Documentation update (changes to documentation or examples)
  • Package (dependencies, versions, package metadata)
  • Development (CI workflows, pre-commit, linters, templates)
  • Security (security related changes)

Testing

Test pass on the new version of pytest_asyncio.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
  • Code changes pass pre-commit (e.g., mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski gpauloski added the internal Refactoring, style changes, testing, or code optimizations label Dec 8, 2023
@gpauloski gpauloski merged commit 7d3cc13 into main Dec 8, 2023
@gpauloski gpauloski deleted the pytest-asyncio-0.23.2 branch December 8, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Refactoring, style changes, testing, or code optimizations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants