Skip to content

Conversation

@gpauloski
Copy link
Collaborator

@gpauloski gpauloski commented Mar 10, 2023

Description

This addresses #124 but does not implement all of the suggestions there. Namely, I've kept a logger for each module so its easy to find where log messages originated from.

Changes:

  • Updated proxystore-globus-auth CLI to use click's prompt/echo rather than standard print/input.
  • Adjusted logging formats.
  • Improved repr(Store)
  • Added __repr__ to the Connector implementations

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (internal implementation changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (no changes to the code)
  • CI change (changes to CI workflows, packages, templates, etc.)
  • Version changes (changes to the package or dependency versions)

Testing

Inspected log messages with --log-cli-level DEBUG in pytest.

Note that some of the click tools will cause pytest to fail with --log-cli-level DEBUG. This is a know issue: pallets/click#824.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, dependencies, documentation, enhancement, refactor).
  • Code changes pass pre-commit (e.g., black, mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski gpauloski added the internal Refactoring, style changes, testing, or code optimizations label Mar 10, 2023
@gpauloski gpauloski merged commit 1cfbd59 into main Mar 10, 2023
@gpauloski gpauloski deleted the issue-124 branch March 10, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Refactoring, style changes, testing, or code optimizations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comprehensive/better (DEBUG level) logging

2 participants