Improve logging throughout the package #243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses #124 but does not implement all of the suggestions there. Namely, I've kept a logger for each module so its easy to find where log messages originated from.
Changes:
proxystore-globus-authCLI to useclick's prompt/echo rather than standard print/input.repr(Store)__repr__to theConnectorimplementationsproxystore.connectors.dimas that module will be totally refactored in Refactorproxystore.connectors.dim#224.Fixes
Type of Change
Testing
Inspected log messages with
--log-cli-level DEBUGin pytest.Note that some of the
clicktools will cause pytest to fail with--log-cli-level DEBUG. This is a know issue: pallets/click#824.Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., black, mypy, ruff, etc.).