-
Notifications
You must be signed in to change notification settings - Fork 16
Closed
Labels
enhancementNew features or improvements to existing functionalityNew features or improvements to existing functionality
Description
Describe the Request
It would be helpful to log when we create a Future and with what key as we do with other Store methods.
proxystore/proxystore/store/base.py
Lines 310 to 321 in 5b428e4
| key = self.connector.new_key() | |
| factory: PollingStoreFactory[ConnectorT, T] = PollingStoreFactory( | |
| key, | |
| store_config=self.config(), | |
| deserializer=deserializer, | |
| evict=evict, | |
| polling_interval=polling_interval, | |
| polling_backoff_factor=polling_backoff_factor, | |
| polling_interval_limit=polling_interval_limit, | |
| polling_timeout=polling_timeout, | |
| ) | |
| return Future(factory, serializer=serializer) |
Also another logging improvement to make:
- Registering a store and unregistering log at different levels which is confusing.
Sample Code
No response
Metadata
Metadata
Assignees
Labels
enhancementNew features or improvements to existing functionalityNew features or improvements to existing functionality