Skip to content

Conversation

@gpauloski
Copy link
Contributor

Description

The Store is not serializable in ProxyStore v0.7.1 so this raises an error. Though, it also was unintentional previously that this variable was captured and then serialized by Dask in the task graph.

Fixes N/A

Type of Change

  • Breaking Change (fix or enhancement which changes existing semantics of the public interface)
  • Enhancement (new features or improvements to existing functionality)
  • Bug (fixes for a bug or issue)
  • Internal (refactoring, style changes, testing, optimizations)
  • Documentation update (changes to documentation or examples)
  • Package (dependencies, versions, package metadata)
  • Development (CI workflows, pre-commit, linters, templates)
  • Security (security related changes)

Testing

Tests pass now.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
  • Code changes pass pre-commit (e.g., mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

The Store is not serializable in ProxyStore v0.7.1 so this raises
an error. Though, it also was unintentional previously.
@gpauloski gpauloski added the bug Something isn't working label Sep 10, 2024
@gpauloski gpauloski merged commit a003424 into main Sep 10, 2024
@gpauloski gpauloski deleted the dask-store-capture branch September 10, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants