Merged
Conversation
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
…to wavm Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
PiotrSikora
reviewed
Aug 4, 2020
Member
PiotrSikora
left a comment
There was a problem hiding this comment.
This looks fine, but is the any way to actually test it?
Shouldn't this be linked against WAVM in this repo? (Same for V8, really)
Contributor
Author
|
yes, we should test in this repo. Currently the tests are in envoy-wasm and I have a PR I am working on which will enable those tests for WAVM. Created issue: #49 |
PiotrSikora
reviewed
Aug 4, 2020
Member
PiotrSikora
left a comment
There was a problem hiding this comment.
Could you at least open the PR in envoy-wasm so that we can verify that this builds on the CI, before merging this? Right now I cannot even tell if this compiles.
Contributor
Author
|
Will do. |
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Contributor
Author
Contributor
Author
|
The attached PR uses these changes to allow WAVM to be used in envoy-wasm. |
PiotrSikora
approved these changes
Aug 4, 2020
PiotrSikora
requested changes
Aug 5, 2020
Signed-off-by: John Plevyak <jplevyak@gmail.com>
PiotrSikora
approved these changes
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Plevyak jplevyak@gmail.com