Merged
Conversation
std=c++20 is used by both v8 and Envoy. Switching to use it is necessary to build with more recent versions of v8, and will also reduce overall build surprises when importing proxy-wasm-cpp-host into Envoy. Signed-off-by: Michael Warres <mpw@google.com>
Signed-off-by: Michael Warres <mpw@google.com>
7f4d30e to
c852939
Compare
These changes make Proxy-Wasm build cleanly with clang-18 and pass clang-tidy-18 checks. Signed-off-by: Matt Leon <mattleon@google.com>
9fd2f6c to
dff346e
Compare
Signed-off-by: Matt Leon <mattleon@google.com>
dff346e to
6d91cbc
Compare
martijneken
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std=c++20 is used by both V8 and Envoy. proxy-wasm-cpp-host needs to switch to use it in order to build with recent versions of V8. This will also reduce build surprises when importing proxy-wasm-cpp-host into Envoy.
This PR obsoletes #439.