Delete unused raw_context arg in host functions.#183
Delete unused raw_context arg in host functions.#183mathetake merged 3 commits intoproxy-wasm:masterfrom
Conversation
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
|
Envoy test passed: envoyproxy/envoy#17547 |
|
What's the reasoning behind this change? Do you need it for something or is it a generic cleanup? It's fine in principle, but I'm asking because the next iteration of the ABI is most likely going to explicitly include handles to host resources (i.e. context) in parameters, at which point we might need to revert this change (I'm not 100% sure yet, since it's not fully fleshed out). |
|
This is the general cleanup. What do you mean by |
|
If this is about context_id as I see in https://github.com/WebAssembly/WASI/blob/b35c78afd6224e5d27484c7613ca0fa46d9ac4c1/meetings/2021/presentations/2021-04-22-PiotrSikora-Proxy-Wasm.pdf, then the revert won't be needed because we can just treat it as Word like we do for other args now. |
It is. My point was that with that change we could simply replace |
This PR deletes unused raw_context arg in host functions which theoretically reduces the cost of each host calls from Wasm VMs.
Signed-off-by: Takeshi Yoneda takeshi@tetrate.io