Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Could you check the presubmit in appveyor? io_win32 related tests seem to be failing. https://ci.appveyor.com/project/protobuf/protobuf/build/1.0.5218/job/ckqiny85mwa3o8mr

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

Ah, the problem is that I removed the CMake-specific temp dir creating logic. Let me fix that.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Could you please rebase this against 3.5.x branch where we need to roll out a fix? Also could also test if this can compile without -std=c++11? (sorry we currently don't have test to cover non-c++11 tests for windows).

Could you please rebase this against 3.5.x branch where we need to roll out a fix?

Yes, but if I do so, how will this PR be upstreamed?

Also could also test if this can compile without -std=c++11? (sorry we currently don't have test to cover non-c++11 tests for windows).

I will do that tomorrow.

We will merge 3.5.x to master then.

Could you please rebase this against 3.5.x branch where we need to roll out a fix?

Yes, but if I do so, how will this PR be upstreamed?

We will merge 3.5.x to master then.

Done.

Also could also test if this can compile without -std=c++11? (sorry we currently don't have test to cover non-c++11 tests for windows).

I will do that tomorrow.

Did you mean using Bazel or CMake? On Windows or Linux?

could you create another PR and select target branch to 3.5.x? (github doesn't seem to allow changing target branch on existing PR)

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@pherl : done, see #4013 .