chore(php): fix chr() deprecation in CodedOutputStream.php#24666
chore(php): fix chr() deprecation in CodedOutputStream.php#24666
Conversation
|
Hi @bshaffer, I'm interested by this fix ; is it possible to tag a new release to trigger the sync on https://github.com/protocolbuffers/protobuf-php/blob/master/src/Google/Protobuf/Internal/CodedOutputStream.php side :) |
|
Hi @VincentLanglet ! I believe a release is expected at the end of January. Unfortunately that's the earliest this fix will be delivered. Sorry for the inconvenience |
Oh. I'm sorry to hear it will be this late :/ I'll try to find a workaround until the release then |
|
@VincentLanglet You can just exclude deprecation logs by configuring your |
Hey @bshaffer, just for my understanding. You mentioned that fix is expected end of January. Would that but v34.0 of this repo and then translate to v4.34.0 of the PHP package? As I've seen v(4.)33.x releases in January. |
|
@WyriHaximus this is now available in google/protobuf:v5.34.0RC1 (see the github release) The 33.x releases won't have it until I backport the fix. I will submit PRs to do that now |
Fix a line in
CodedOutputStreamto get rid of a new deprecation in PHP 8.5: