Rename maven install back to maven in MODULE.bazel#22544
Closed
meteorcloudy wants to merge 5 commits intoprotocolbuffers:mainfrom
Closed
Rename maven install back to maven in MODULE.bazel#22544meteorcloudy wants to merge 5 commits intoprotocolbuffers:mainfrom
maven in MODULE.bazel#22544meteorcloudy wants to merge 5 commits intoprotocolbuffers:mainfrom
Conversation
Contributor
Author
maven in MODULE.bazel
Contributor
Author
|
This change is implemented internally at cl/781031722 |
Contributor
That target is aliased to I figured the change was safe since it only impacted test-only targets: https://github.com/protocolbuffers/protobuf/pull/18641/files That said, I don't use Java directly—my only goal was to silence the warning. Since that's now possible, I no longer have skin in the game. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21177
This PR essentially reverts #18641, which claimed
This is not true since targets like
@com_google_protobuf//:protobuf_javaare meant to be consumed by other projects, therefore protobuf should not use a private maven install namespace. Otherwise, it leads to duplicated maven jars and classpath conflicts. See #21177 and bazel-contrib/rules_jvm_external#916 (comment)The original warning message caused by multiple modules contributing to
mavencan be suppressed with bazel-contrib/rules_jvm_external#1393, which will be available in rules_jvm_external 6.8.