Change how we decide which empty string implementation to use.#20690
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 17, 2025
Merged
Change how we decide which empty string implementation to use.#20690copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
c097c8b to
aef6531
Compare
The feature macro seems to be lying on some toolchains. Instead, ask the compiler to try to run the default constructor in constexpr context which should fail if the implementation doesn't actually support it and fallback to the dynamic one. This should fix #20645 PiperOrigin-RevId: 737603382
aef6531 to
3dfd88f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change how we decide which empty string implementation to use.
The feature macro seems to be lying on some toolchains. Instead, ask the
compiler to try to run the default constructor in constexpr context which
should fail if the implementation doesn't actually support it and fallback to
the dynamic one.
This should fix #20645