-
Notifications
You must be signed in to change notification settings - Fork 16.1k
Comparing changes
Open a pull request
base repository: protocolbuffers/protobuf
base: v5.29.0
head repository: protocolbuffers/protobuf
compare: v5.29.2
- 13 commits
- 71 files changed
- 9 contributors
Commits on Nov 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9e78ac7 - Browse repository at this point
Copy the full SHA 9e78ac7View commit details -
Merge pull request #19425 from protocolbuffers/29.x-202411271837
Merge release commits to 29.x
Configuration menu - View commit details
-
Copy full SHA for e0a3978 - Browse repository at this point
Copy the full SHA e0a3978View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5864b50 - Browse repository at this point
Copy the full SHA 5864b50View commit details
Commits on Dec 2, 2024
-
Rename maven to protobuf_maven in MODULE.bazel (#18641) (#19477)
The default name for the rules_jvm_external.maven rule is "maven". When not set, it defaults to "maven". For root modules also using rules_jvm_external, the name clash causes a warning: ``` DEBUG: $TMP/external/rules_jvm_external~/private/extensions/maven.bzl:154:14: The maven repository 'maven' is used in two different bazel modules, originally in '<my_workspace>' and now in 'protobuf' ``` Summarizing @shs96c in [1]: > The common maven repo name allows rulesets to contribute to the user's JARs. > However, this implies that maven is for the end user, not for transitive > dependencies. If a ruleset needs private dependencies, it should use a custom > namespace rather than the maven namespace. Since protobuf is not contributing to user's JARs, we'll use a custom namespace. There's precedent for using a custom namespace for library modules: - rules_jvm_external uses `rules_jvm_external_deps` instead of `maven`. - rules_kotlin uses `kotlin_rules_maven` instead of `maven`. [1]: bazel-contrib/rules_jvm_external#916 (comment) Fixes #16839. Closes #18641 COPYBARA_INTEGRATE_REVIEW=#18641 from jschaf:joe/protobuf-maven bd2c62f PiperOrigin-RevId: 684625084 Co-authored-by: Joe Schafer <joe.schafer@delta46.us>
Configuration menu - View commit details
-
Copy full SHA for ba6da44 - Browse repository at this point
Copy the full SHA ba6da44View commit details
Commits on Dec 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 796e49f - Browse repository at this point
Copy the full SHA 796e49fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3e9db8 - Browse repository at this point
Copy the full SHA a3e9db8View commit details -
Merge pull request #19506 from protocolbuffers/29.x-202412032207
Merge release commits to 29.x
Configuration menu - View commit details
-
Copy full SHA for d7d3da6 - Browse repository at this point
Copy the full SHA d7d3da6View commit details
Commits on Dec 12, 2024
-
Remove CMake downgrade workaround from Windows CI tests (#19630)
This should fix some Windows tests that are failing to install a downgraded CMake version. I also fixed some of the Bazel examples tests. Two of the test runs seemed to be omitting a Bazel version and were inadvertently using Bazel 8.
Adam Cozzette authoredDec 12, 2024 Configuration menu - View commit details
-
Copy full SHA for 3a7bb4a - Browse repository at this point
Copy the full SHA 3a7bb4aView commit details
Commits on Dec 16, 2024
-
Remove unused / invalid C++ lazy repeated field code from OSS. (#19682)
Fixes #19671 PiperOrigin-RevId: 706729524
Configuration menu - View commit details
-
Copy full SHA for 3649f87 - Browse repository at this point
Copy the full SHA 3649f87View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1c9b6a - Browse repository at this point
Copy the full SHA a1c9b6aView commit details -
Export environment variables so bazelisk picks them up (#19690)
PiperOrigin-RevId: 705148623 Co-authored-by: Mike Kruskal <mkruskal@google.com>
Configuration menu - View commit details
-
Copy full SHA for 8b9d76c - Browse repository at this point
Copy the full SHA 8b9d76cView commit details
Commits on Dec 17, 2024
-
Automated rollback of commit 23aada2. (#19692)
PiperOrigin-RevId: 706827598 Co-authored-by: Protobuf Team Bot <protobuf-github-bot@google.com>
Configuration menu - View commit details
-
Copy full SHA for 1772657 - Browse repository at this point
Copy the full SHA 1772657View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2330983 - Browse repository at this point
Copy the full SHA 2330983View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v5.29.0...v5.29.2