Skip to content

Commit b882eb7

Browse files
mkruskal-googlecopybara-github
authored andcommitted
Migrate windows upb tests to bzlmod.
This requires dropping the python tests, which were never actually being run due to system_python's silent failure mode on windows. These tests could actually be enabled with some fixes in rules_python PiperOrigin-RevId: 811863667
1 parent 913b0ca commit b882eb7

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

.github/workflows/test_upb.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,8 @@ jobs:
9191
with:
9292
credentials: ${{ secrets.GAR_SERVICE_ACCOUNT }}
9393
bazel-cache: "upb-bazel-windows"
94-
bazel: test //upb/... //upb_generator/... //python/... --noenable_bzlmod
94+
# TODO: Enable python tests here once rules_python supports Windows better.
95+
bazel: test //upb/... //upb_generator/...
9596
version: 7.6.1
9697
exclude-targets: -//python:conformance_test -//upb/reflection:def_builder_test
9798

0 commit comments

Comments
 (0)