This repository was archived by the owner on Aug 29, 2023. It is now read-only.
Replace concurrency setup with max-parallel=1 strategy in copy-workflow#243
Merged
Replace concurrency setup with max-parallel=1 strategy in copy-workflow#243
Conversation
marten-seemann
approved these changes
Dec 10, 2021
Contributor
marten-seemann
left a comment
There was a problem hiding this comment.
According to my understanding:
- With ~180 repos, we'll end up with 9 copy workflows.
- In each of these copy workflows, only one job is running.
That means, we'll have a max of 9 concurrent deployments running.
Contributor
Author
|
I've verified that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With current
concurrencysetup only the first and the last matrix job was run and the rest were cancelled withCanceling since a higher priority waiting request for 'copy-*' exists.The concurrency documentations explains this as follows:
I think settings
strategy.max-parallel: 1incopy-workflowmight do what we want it to which is to run all the matrix jobs within one copy-workflow instance sequentially: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idstrategymax-parallelOne thing to watch out for is if the job sequence will continue after a failure but I think it will because of the
fail-fast: falsesetting.