Conversation
85f0f5c to
043571c
Compare
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
I feel like this is adding yet another standard on top of the existing pylint: disable and noqa from Ruff/flake8 and type:ignore from mypy. Not sure if it's a good thing. (In pylint there's an issue to make noqa work on top of pylint: disable to avoid having various standard). Once you use this it makes the codebase prospector dependant.
20f9a75 to
672e714
Compare
672e714 to
9340a04
Compare
|
I just removed the adding of |
|
And I create in issue for the rest of the code: #715 :-) |
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Why introduce 'flake8: noqa' when flake8 itself uses noqa: and Ruff that include flake8 also use raw noqa ? It force the user to know from which software a message is coming to noqa it which make the tool harder to use without a lot of prior knowledge. Flake8 isn't asking the user to know that it's a collection of 3 tools for exemple. It would be annoying to have to do '# pycodestyle: noqa' or '# pyflake: noqa' or '# McCabe: noqa'. (And if you use a number of tool you'll end up with devilish line like '# type ignore noqa: ruf001 flake8: noqa: F408')
|
With the current code, I didn't introduce anything except the possibility to disable the prospector In my code, I don't like to ignore all the issues with won comment because with that, we don't know what's ignored, Finally, we can prefer to have the control with a long line or just ignore anything that we don't know with a short line. |
This is pretty bad, but shouldn't it be fixed in bandit ? |
|
Fix in bandit that Prospector hide his issue? With the current code at least we have |
|
I'm not quite following here, so please correct me. Is the problem that disabling a message for ruff will disable the equivalent message from other tools? If so that's intended behaviour of the "blender" which tries to remove duplicate warnings. This can be disabled with the Or is the problem that Or what am I missing? |
|
Hello @carlio it's the second, I can work on a better implementation or |
|
My bad I misunderstood what you were saying. |
|
No problème @Pierre-Sassoulas :-) |
Description
Be able to configure the suppression, add
# prospector: ignore=<source>.<code>Motivation and Context
I don't like the
# noqabecause he is too generic, => be able to deactivate itAdd a new suppression to be able to suppress only one error code
Types of changes