Implement isatty() to make the CaptureOutput compatible with Django requirements #704
Merged
Implement isatty() to make the CaptureOutput compatible with Django requirements #704
Conversation
…es, so the capture output stream needs to minic this behaviour for cases where prospector is being used with Django
e31c8b2 to
16af5ba
Compare
Pierre-Sassoulas
approved these changes
Nov 19, 2024
Collaborator
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Wouldn't have noticed the spelling in the branch name.. if you didn't point it out 😄
sbrunner
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using prospector (with pylint) on a Django project, Django runs into a problem testing whether the sysout/stderr is a TTY, but prospector wraps that in CaptureOutput.
Please ignore that I can't spell "bugfix" in the branch name 🙄
Related Issue
Fixes #703
Motivation and Context
This PR implements that particular test for the case of prospector+Django
How Has This Been Tested?
I had this problem on my own local project, and this code fixed it - it was a simple missing implementation on the wrapper class.
Types of changes
Checklist: