This repository was archived by the owner on Jul 7, 2021. It is now read-only.
Merged
Conversation
ccostin93
commented
Nov 21, 2020
| .withQueryStringParameter("search", "just+a+word") | ||
| .withQueryStringParameter("accountTypes", "Checking%2CSecurity") | ||
| .withQueryStringParameter("bankConnectionIds", "3%2C4") | ||
| .withQueryStringParameter("ids", "1,2") |
Collaborator
Author
There was a problem hiding this comment.
When using UriUtils.encodeQueryParam, comma , is allowed in the query params.
I also retested queries against finAPI Sandbox and even with un-encoded comma, the request is correctly interpreted
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
============================================
- Coverage 83.99% 83.97% -0.03%
- Complexity 1035 1039 +4
============================================
Files 175 176 +1
Lines 2555 2564 +9
Branches 20 20
============================================
+ Hits 2146 2153 +7
- Misses 391 393 +2
Partials 18 18
Continue to review full report at Codecov.
|
| </dependency> | ||
| <dependency> | ||
| <groupId>org.springframework</groupId> | ||
| <artifactId>spring-web</artifactId> |
Owner
There was a problem hiding this comment.
yeah, my idea was the same - just add this dependency. But maybe there is a smaller lib with the same functionality?
proshin-roman
previously approved these changes
Nov 21, 2020
86e9eed to
b90fbc1
Compare
proshin-roman
previously approved these changes
Nov 21, 2020
# Conflicts: # src/main/java/org/proshin/finapi/transaction/in/DeleteTransactionsCriteria.java
proshin-roman
approved these changes
Nov 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.