Skip to content
This repository was archived by the owner on Jul 7, 2021. It is now read-only.

Fix code formatting#326

Merged
proshin-roman merged 4 commits intomasterfrom
fix-code-formatting
Jul 23, 2020
Merged

Fix code formatting#326
proshin-roman merged 4 commits intomasterfrom
fix-code-formatting

Conversation

@ccostin93
Copy link
Collaborator

@ccostin93 ccostin93 commented Jul 20, 2020

  • use standard HttpStatus constants
  • add Nonnull annotations
  • fix some code warnings

@ccostin93 ccostin93 requested a review from proshin-roman July 20, 2020 23:40
@ccostin93 ccostin93 self-assigned this Jul 20, 2020
@codecov
Copy link

codecov bot commented Jul 21, 2020 •
edited
Loading

Codecov Report

Merging #326 into master will decrease coverage by 0.04%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #326      +/-   ##
============================================
- Coverage     82.95%   82.90%   -0.05%     
  Complexity      966      966              
============================================
  Files           169      169              
  Lines          2540     2533       -7     
  Branches         21       21              
============================================
- Hits           2107     2100       -7     
  Misses          414      414              
  Partials         19       19
Impacted Files Coverage Δ Complexity Δ
...org/proshin/finapi/accesstoken/FpAccessTokens.java 96.15% <ø> (-0.52%) 7.00 <0.00> (ø)
...oshin/finapi/account/in/DailyBalancesCriteria.java 100.00% <ø> (ø) 10.00 <0.00> (ø)
...org/proshin/finapi/account/in/FpQueryCriteria.java 100.00% <ø> (ø) 11.00 <0.00> (ø)
...java/org/proshin/finapi/bank/in/BanksCriteria.java 92.85% <ø> (ø) 13.00 <0.00> (ø)
...roshin/finapi/bankconnection/FpBankConnection.java 69.76% <ø> (ø) 18.00 <0.00> (ø)
.../proshin/finapi/category/in/CashFlowsCriteria.java 100.00% <ø> (ø) 22.00 <0.00> (ø)
...proshin/finapi/category/in/CategoriesCriteria.java 100.00% <ø> (ø) 9.00 <0.00> (ø)
...org/proshin/finapi/client/out/FpConfiguration.java 86.95% <ø> (ø) 17.00 <0.00> (ø)
...ain/java/org/proshin/finapi/endpoint/Endpoint.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
...n/java/org/proshin/finapi/endpoint/FpEndpoint.java 66.66% <0.00%> (-0.35%) 12.00 <0.00> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f97e9c8...f8f52d2. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 23, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

66.7% 66.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@proshin-roman proshin-roman merged commit 4f47a3d into master Jul 23, 2020
@proshin-roman proshin-roman deleted the fix-code-formatting branch July 23, 2020 20:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@proshin-roman proshin-roman proshin-roman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ccostin93 ccostin93

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ccostin93 @proshin-roman