This repository was archived by the owner on Jul 7, 2021. It is now read-only.
Bump json from 20180813 to 20200518#321
Merged
proshin-roman merged 7 commits intomasterfrom Aug 26, 2020
Merged
Conversation
Collaborator
|
@dependabot rebase |
Bumps [json](https://github.com/douglascrockford/JSON-java) from 20180813 to 20200518. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Commits](https://github.com/douglascrockford/JSON-java/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
664c665 to
7fb402c
Compare
ccostin93
reviewed
Aug 11, 2020
|
|
||
| public OptionalBigDecimalOf(final JSONObject origin, final String name) { | ||
| this(new OptionalOf<>(origin, name, JSONObject::getBigDecimal)); | ||
| this(new OptionalOf<>(origin, name, (json, key) -> new BigDecimal(json.optString(key)))); |
Collaborator
There was a problem hiding this comment.
I think it's easier if we just read the value as a string and then convert it to BigDecimal as it is, since the precision is already ensured by finAPI.
Owner
There was a problem hiding this comment.
yeah, ok, only one thing: not optString, but getString as the third parameter can only be triggered if the field is actually presented in the JSON
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
============================================
+ Coverage 83.86% 83.99% +0.12%
- Complexity 1031 1035 +4
============================================
Files 174 175 +1
Lines 2548 2555 +7
Branches 20 20
============================================
+ Hits 2137 2146 +9
+ Misses 392 391 -1
+ Partials 19 18 -1
Continue to review full report at Codecov.
|
|
SonarCloud Quality Gate failed.
|
proshin-roman
approved these changes
Aug 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps json from 20180813 to 20200518.
Release notes
Sourced from json's releases.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: