Merged
Conversation
pableu
reviewed
Feb 8, 2024
pableu
reviewed
Feb 8, 2024
…nications/Propel2 into allow_symfony_7 # Conflicts: # src/Propel/Runtime/Validator/Constraints/Date.php # tests/Propel/Tests/Common/Config/Loader/FileLoaderTest.php
pableu
approved these changes
Feb 17, 2024
Contributor
|
Can we get this merged and tag a new beta version @PhilinTv? |
Contributor
PhilinTv
reviewed
Mar 23, 2024
| "symfony/finder": "^4.4.0 || ^5.0.0 || ^6.0.0", | ||
| "symfony/translation": "^4.4.0 || ^5.0.0 || ^6.0.0", | ||
| "symfony/validator": "^4.4.0 || ^5.0.0 || ^6.0.0" | ||
| "symfony/yaml": "^4.4.0 || ^5.0.0 || ^6.0.0 || ^7.0.0", |
Contributor
There was a problem hiding this comment.
Feels like the right time to drop 4x support 😈
PhilinTv
approved these changes
Mar 23, 2024
Contributor
PhilinTv
left a comment
There was a problem hiding this comment.
Great PR! Clean and clear 💎
Contributor
Author
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1992 +/- ##
=========================================
Coverage 89.28% 89.28%
Complexity 8058 8058
=========================================
Files 232 232
Lines 24534 24534
=========================================
Hits 21905 21905
Misses 2629 2629
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.