Make compatible with 8.2 ArrayIterator interface updates#1987
Merged
PhilinTv merged 5 commits intopropelorm:masterfrom Feb 4, 2024
Merged
Make compatible with 8.2 ArrayIterator interface updates#1987PhilinTv merged 5 commits intopropelorm:masterfrom
PhilinTv merged 5 commits intopropelorm:masterfrom
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1987 +/- ##
=========================================
Coverage 89.28% 89.28%
Complexity 8058 8058
=========================================
Files 232 232
Lines 24534 24534
=========================================
Hits 21905 21905
Misses 2629 2629
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Hey @oojacoboo , have a look at d2bc7b8 for the current linter fix |
Contributor
Author
|
@mringler yea, was looking at old logs and thinking it was still failing - fixed. |
PhilinTv
approved these changes
Feb 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArrayIteratorinterface has gone with explicittruereturn values for sort methods. However, PHP less than 8.2 will crap out on this. We, instead, add the#[\ReturnTypeWillChange]attribute until we can make 8.2 the minimum supported version.This replaces/closes #1984