fix tests after Symfony PropertyInfo update#1973
Merged
gechetspr merged 1 commit intopropelorm:masterfrom Sep 4, 2023
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1973 +/- ##
============================================
+ Coverage 88.56% 89.25% +0.69%
Complexity 8051 8051
============================================
Files 243 232 -11
Lines 24590 24544 -46
============================================
+ Hits 21777 21906 +129
+ Misses 2813 2638 -175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'll get this merged, it makes sense. |
gechetspr
approved these changes
Sep 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current Symfony components, one test in the 5-max and and 6-max group fails, see for example this run.
Apparently, the Symfony PropertyInfo has changed internally, and now an assertion fails. A comment in the test acknowledges that it tests Symfony internals:
Examining
$fictionMetadatas, I can see that bothValidateTriggerFictionandValidateTriggerBookare present in$fictionMetadatas[0].constraintsByGroup:This is also successfully tested in the rest of the test case.
So apparently the PropertyInfo component now groups those constraints in the same PropertyMetadata object instead of using a new object for each. But this does not concern Propel. So we can just remove that assertion. We could also turn it into
assertNotEmpty(), but that is tested implicitly in the next assertion.