Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1902 +/- ##
============================================
+ Coverage 87.61% 87.64% +0.02%
- Complexity 7818 7826 +8
============================================
Files 227 227
Lines 21161 21180 +19
============================================
+ Hits 18540 18563 +23
+ Misses 2621 2617 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
a0df3bb to
b64f3dd
Compare
508520c to
3646296
Compare
3646296 to
26eea73
Compare
dereuromark
reviewed
Aug 9, 2022
dereuromark
reviewed
Aug 9, 2022
dereuromark
reviewed
Aug 9, 2022
b045f1f to
09df751
Compare
dereuromark
reviewed
Aug 9, 2022
|
Local testing with 350 tables: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1901
When adding table classes to a Propel database object, currently those classes are immediately instantiated, event though many of those classes will not be used in one cycle, leading to unnecessary overhead, particularly on databases with lots of tables.
A simple fix is to add tables as class strings, and only instantiate them when they are actually used.
The way it is implemented here, the
$tablesand$tablesByPhpNameproperties of DatabaseMap now can contain both TableMap objects or class strings, which is not ideal, but it seems to be the most seamless integration of this change. Let me know if there is a better way.