refactor(store): delete dead per-row Import* API (links-store-cleanup-bex7)#217
Merged
Conversation
…-bex7) ImportIssue, ImportComment, ImportRelation, ImportLabel and their four input structs had zero callers — ReplaceFromExport is the only live import path. [LAW:carrying-cost] Dead exported API still costs maintenance: the RelationType refactor had to convert ImportRelation just to keep it compiling. Remove the dead surface; the import contract is now unambiguously atomic via ReplaceFromExport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImportIssue,ImportComment,ImportRelation,ImportLabelmethods and their four input structs frominternal/store/import_export.go— zero callers existed anywhere in the moduleerrorsimportReplaceFromExportis the only live import path and remains unchangedContext
[LAW:carrying-cost]: The per-row Import* API had no callers but still exacted maintenance cost — the RelationType refactor (PR #206) had to convertImportRelationtomodel.ParseRelationTypejust to keep it compiling. Removing the dead surface makes the import contract unambiguous: restore is atomic viaReplaceFromExport, not incremental via per-row calls.Test plan
go test ./...clean (verified locally — all 22 packages pass)