refactor(cli): absorb error-reason classification into typed errors (links-va-001-error-reason-3dy.1)#214
Merged
Conversation
…delete 11+ string-match patterns (links-va-001-error-reason-3dy.1) Add UsageError, UnknownCommandError, ValidationError, UnsupportedError, OutsideWorkspaceError to cli package; add store.ValidationError for domain constraint violations. Wrap all 46+ usage/validation/unsupported error sources. Replace every strings.Contains/HasPrefix check in exit.go and error_output.go with errors.As dispatch — zero string inspection remains in the two classification sinks. Tests updated to use typed errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/cli/:UsageError,UnknownCommandError,ValidationError,UnsupportedError,OutsideWorkspaceErrorstore.ValidationErrorfor domain constraint violations (issue type, priority)strings.Contains/HasPrefixchecks inexit.goanderror_output.go; both sinks now dispatch viaerrors.As— zero message-text inspection remainsTest plan
go test ./...— all 22 packages passexit.gohas zerostrings.imports or callserror_output.gohas zerostrings.imports or callsTestExitCodeMappingsexercises typed error → exit code mappingTestBuildCommandErrorPayloadUnknownCommand/TestWriteCommandErrorJSON/TestWriteCommandErrorTextexercise typed error → reason/code/remediation mapping