fix: sns templating issue#8320
Merged
slashpai merged 3 commits intoprometheus-operator:mainfrom Jan 29, 2026
Merged
Conversation
34d3610 to
1cb2a9d
Compare
6 tasks
slashpai
reviewed
Jan 27, 2026
9027488 to
b19bc58
Compare
Contributor
|
Can you rebase release branch is merged back to main now |
3061ce9 to
0809987
Compare
0809987 to
c5b6c15
Compare
Member
Author
Done thanks |
Member
Author
|
not sure why the e2e test are failing as I've adjusted the SNSConfigs in |
slashpai
approved these changes
Jan 29, 2026
Contributor
|
@heliapb unrelated to PR but I think if you are ok you can add Signoff message in commit message |
Member
Author
I know 😉 but since last week somehow it didn't work so I changed to gpg signing key instead, will revise my configs maybe something is missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Relates to: #8315, undo api url checks in https://github.com/prometheus-operator/prometheus-operator/pull/8217/changes to allow templating as per https://prometheus.io/docs/alerting/latest/configuration/#sns_config
If you're contributing for the first-time, check our contribution guidelines.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.