feat: Add scope support for AzureAD Remote Write#8240
Merged
simonpasquier merged 2 commits intoprometheus-operator:mainfrom Jan 7, 2026
Merged
feat: Add scope support for AzureAD Remote Write#8240simonpasquier merged 2 commits intoprometheus-operator:mainfrom
simonpasquier merged 2 commits intoprometheus-operator:mainfrom
Conversation
a30a6d5 to
0c5b04f
Compare
Contributor
simonpasquier
left a comment
There was a problem hiding this comment.
one small nit otherwise LGTM
7c90428 to
e60485c
Compare
simonpasquier
approved these changes
Jan 7, 2026
auto-merge was automatically disabled
January 7, 2026 10:32
Head branch was pushed to by a user without write access
e60485c to
fdd5e1a
Compare
simonpasquier
previously approved these changes
Jan 7, 2026
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
auto-merge was automatically disabled
January 7, 2026 11:47
Head branch was pushed to by a user without write access
fdd5e1a to
6dcaf3f
Compare
Member
Author
|
Hi @simonpasquier sorry needs another check since with #7998 merge needed to fix conflicts |
simonpasquier
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add scope support to azuread remote write, from prometheus/prometheus#17483 in prometheus 3.9.0
If you're contributing for the first-time, check our contribution guidelines.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.