Skip to content

Feat: Add Validations to Pushover Receiver in Alertmanager Config CR#8239

Merged
simonpasquier merged 5 commits intoprometheus-operator:mainfrom
nutmos:feat/add-pushover-receiver-cr-validation
Jan 7, 2026
Merged

Feat: Add Validations to Pushover Receiver in Alertmanager Config CR#8239
simonpasquier merged 5 commits intoprometheus-operator:mainfrom
nutmos:feat/add-pushover-receiver-cr-validation

Conversation

@nutmos
Copy link
Contributor

@nutmos nutmos commented Jan 6, 2026

Description

This PR adds validations to Pushover Receiver in Alertmanager Config CR

  1. Change from string to *URL type for the URL parameters
  2. Add MinLength=1 validation for optional string parameters
  3. Change from string to *string for optional string parameters

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Unit Testing

Changelog entry

- Add validations to Pushover Receiver in Alertmanager Config CR

…onversion method

to have more strict validations
@nutmos nutmos requested a review from a team as a code owner January 6, 2026 09:15
nutmos added 2 commits January 6, 2026 17:19
to cover more use case of validation
to fix var error
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@simonpasquier simonpasquier enabled auto-merge (squash) January 6, 2026 13:58
@simonpasquier simonpasquier requested a review from slashpai January 6, 2026 13:58
auto-merge was automatically disabled January 6, 2026 23:48

Head branch was pushed to by a user without write access

@simonpasquier simonpasquier merged commit a5f0f7f into prometheus-operator:main Jan 7, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants