pkg/alertmanager: add URL validation for MSTeams receiver#8231
Merged
simonpasquier merged 1 commit intoprometheus-operator:mainfrom Jan 7, 2026
Merged
Conversation
2b9df27 to
05e2e52
Compare
Member
|
Hi @tomlin7 #8233 (comment) I guess this comment also make sense here, let's get some feedback, otherwise lgtm |
simonpasquier
previously approved these changes
Jan 7, 2026
Contributor
|
@tomlin7 can you rebase? likely you might need to rebase other validation prs based on what gets merged first |
Contributor
Author
|
@slashpai I'll update this as soon as the MSTeamsV2 pr is handled. Otherwise I'll be facing same conflict again. |
Adds URL validation for MSTeams receiver configuration fields when loaded from secrets. This ensures URLs are validated regardless of whether configurations come from CustomResources or secrets.
05e2e52 to
27f8c3b
Compare
Contributor
Author
@simonpasquier this was pending, but now that it's merged, I guess I can combine all similar changes to one PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds URL validation for MSTeams receiver configuration fields when loaded from secrets. This ensures URLs are validated regardless of whether configurations come from CustomResources or secrets.
Validated fields:
webhook_urlRelates to #8193
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
msteams invalid webhook_url returns error)msteams valid webhook_url passes validation) with golden fileChangelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.