Skip to content

Feat: Add VictorOps Receiver CR Validations#8220

Merged
simonpasquier merged 6 commits intoprometheus-operator:mainfrom
nutmos:feat/add-victorops-url-validation-1
Jan 5, 2026
Merged

Feat: Add VictorOps Receiver CR Validations#8220
simonpasquier merged 6 commits intoprometheus-operator:mainfrom
nutmos:feat/add-victorops-url-validation-1

Conversation

@nutmos
Copy link
Contributor

@nutmos nutmos commented Dec 29, 2025

Description

Add more validations to VictorOps Receiver in Custom Resources

  • Change apiURL type from string to URL
  • Update string to *string for optional values
  • Change routingKey from optional to required
  • Add MinLength=1 for every string parameter

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Unit testing

Changelog entry

- Add validations to VictorOps receiver in Custom Resource

to add more validation
@nutmos nutmos requested a review from a team as a code owner December 29, 2025 12:37
@pull-request-size pull-request-size bot added size/M and removed size/L labels Dec 31, 2025
to address the variable type issue
@nutmos nutmos marked this pull request as draft December 31, 2025 23:22
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 5, 2026
@nutmos nutmos marked this pull request as ready for review January 5, 2026 13:20
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simonpasquier simonpasquier merged commit 137c9ef into prometheus-operator:main Jan 5, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants